From: Devendra Naga Date: Wed, 19 Sep 2012 21:04:36 +0000 (+0000) Subject: at91ether: return PTR_ERR if call to clk_get fails X-Git-Tag: upstream/snapshot3+hdmi~6666^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3cfc1590107a155218c97df0db3eb0a2bd7fda16;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git at91ether: return PTR_ERR if call to clk_get fails we are currently returning ENODEV, as the clk_get may give a exact error code in its returned pointer, assign it to the ret by using the PTR_ERR function, so that the subsequent goto label will jump to the error path and clean the driver and return the error correctly. Signed-off-by: Devendra Naga Acked-by: Nicolas Ferre Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/cadence/at91_ether.c b/drivers/net/ethernet/cadence/at91_ether.c index 7788419..4e980a7 100644 --- a/drivers/net/ethernet/cadence/at91_ether.c +++ b/drivers/net/ethernet/cadence/at91_ether.c @@ -1086,7 +1086,7 @@ static int __init at91ether_probe(struct platform_device *pdev) /* Clock */ lp->ether_clk = clk_get(&pdev->dev, "ether_clk"); if (IS_ERR(lp->ether_clk)) { - res = -ENODEV; + res = PTR_ERR(lp->ether_clk); goto err_ioumap; } clk_enable(lp->ether_clk);