From: Gao Feng Date: Sun, 28 Aug 2016 13:41:22 +0000 (+0800) Subject: netfilter: log_arp: Use ARPHRD_ETHER instead of literal '1' X-Git-Tag: v5.15~12760^2~291^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3cb27991aad74299af2cd55a9c12684f5b0c76c6;p=platform%2Fkernel%2Flinux-starfive.git netfilter: log_arp: Use ARPHRD_ETHER instead of literal '1' There is one macro ARPHRD_ETHER which defines the ethernet proto for ARP, so we could use it instead of the literal number '1'. Signed-off-by: Gao Feng Signed-off-by: Pablo Neira Ayuso --- diff --git a/net/ipv4/netfilter/nf_log_arp.c b/net/ipv4/netfilter/nf_log_arp.c index e7ad950..cf8f2d4 100644 --- a/net/ipv4/netfilter/nf_log_arp.c +++ b/net/ipv4/netfilter/nf_log_arp.c @@ -62,7 +62,7 @@ static void dump_arp_packet(struct nf_log_buf *m, /* If it's for Ethernet and the lengths are OK, then log the ARP * payload. */ - if (ah->ar_hrd != htons(1) || + if (ah->ar_hrd != htons(ARPHRD_ETHER) || ah->ar_hln != ETH_ALEN || ah->ar_pln != sizeof(__be32)) return;