From: billh <billh@e2bd861d-eb25-0410-b326-f6ed22b6b98c>
Date: Tue, 20 Aug 2002 12:37:34 +0000 (+0000)
Subject: Updated HACKING, and fixed memory leak in libspi/text.c
X-Git-Tag: AT_SPI2_CORE_0_1_3~871
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3caeb74020e4348bf0188b936a1e76be1834b291;p=platform%2Fupstream%2Fat-spi2-core.git

Updated HACKING, and fixed memory leak in libspi/text.c
Also started 'TODO' list for API additions suggested/desired for 2.2.


git-svn-id: http://svn.gnome.org/svn/at-spi/trunk@335 e2bd861d-eb25-0410-b326-f6ed22b6b98c
---

diff --git a/ChangeLog b/ChangeLog
index b64d24a..723be30 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2002-08-20  Bill Haneman <bill.haneman@sun.com>
+
+	* HACKING: 
+	Clarified and reworded our commit policy.
+
+	* NEWS:
+	Started an API "todo" addition list for 2.2.
+
+	* libspi/text.c:
+	(impl_getSelection):
+	Free char pointer from atk_text_get_selection, which was being leaked.
+
 2002-08-19  Bill Haneman <bill.haneman@sun.com>
 
 	* AUTHORS: 
diff --git a/NEWS b/NEWS
index e902a9a..d06a90c 100644
--- a/NEWS
+++ b/NEWS
@@ -69,6 +69,24 @@ API CHANGES:
   returns.
 
 * Made Accessibility_StateSet inherit from BonoboUnknown as it should;
-  this was the main existing breakage in StateSet.
+this was the main existing breakage in StateSet.
+
+
+=================
+
+
+TODO API Additions:
+
+getStateName () and STATE_EXTENDED to allow extension of State API (already 
+in ATK).
+
+AccessibleAction_getType () and AccessibleAction_getTypeName ().
+
+need getBaseAttributes () 
+for AccessibleText (available in ATK I think).
+
+table: getVisibleRange
+
+state: HEADER, etc. for spreadsheet cells
 
 
diff --git a/libspi/text.c b/libspi/text.c
index 9c5f85b..b9c2546 100644
--- a/libspi/text.c
+++ b/libspi/text.c
@@ -324,8 +324,10 @@ impl_getSelection (PortableServer_Servant servant,
   
   g_return_if_fail (text != NULL);
 
-  atk_text_get_selection (text, selectionNum,
-			  &intStartOffset, &intEndOffset);
+  /* atk_text_get_selection returns gchar* which we discard */
+  g_free (atk_text_get_selection (text, selectionNum,
+				  &intStartOffset, &intEndOffset));
+  
   *startOffset = intStartOffset;
   *endOffset = intEndOffset;
 }