From: Thierry Reding Date: Tue, 25 Nov 2014 12:05:12 +0000 (+0100) Subject: drm/plane: Make ->atomic_update() mandatory X-Git-Tag: v4.0-rc1~74^2~25^2~35 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3cad4b6887cd3d2b4e7f2c0ad6cb557b8eda4084;p=platform%2Fkernel%2Flinux-exynos.git drm/plane: Make ->atomic_update() mandatory There is no use-case where it would be useful for drivers not to implement this function and the transitional plane helpers already require drivers to provide an implementation. v2: add new requirement to kerneldoc Reviewed-by: Daniel Vetter Signed-off-by: Thierry Reding --- diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 541ba83..6c72c57 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -1108,7 +1108,7 @@ void drm_atomic_helper_commit_planes(struct drm_device *dev, funcs = plane->helper_private; - if (!funcs || !funcs->atomic_update) + if (!funcs) continue; old_plane_state = old_state->plane_states[i]; diff --git a/include/drm/drm_plane_helper.h b/include/drm/drm_plane_helper.h index a185392..06d0314 100644 --- a/include/drm/drm_plane_helper.h +++ b/include/drm/drm_plane_helper.h @@ -52,7 +52,7 @@ extern int drm_crtc_init(struct drm_device *dev, * @prepare_fb: prepare a framebuffer for use by the plane * @cleanup_fb: cleanup a framebuffer when it's no longer used by the plane * @atomic_check: check that a given atomic state is valid and can be applied - * @atomic_update: apply an atomic state to the plane + * @atomic_update: apply an atomic state to the plane (mandatory) * * The helper operations are called by the mid-layer CRTC helper. */