From: Jiri Kosina Date: Wed, 27 Oct 2021 08:04:10 +0000 (+0200) Subject: HID: playstation: fix return from dualsense_player_led_set_brightness() X-Git-Tag: v6.1-rc5~2717^2~4^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3c92cb4cb60c71b574e47108ead8b6f0470850db;p=platform%2Fkernel%2Flinux-starfive.git HID: playstation: fix return from dualsense_player_led_set_brightness() brightness_set_blocking() callback expects function returning int. This fixes the follwoing build failure: drivers/hid/hid-playstation.c: In function ‘dualsense_player_led_set_brightness’: drivers/hid/hid-playstation.c:885:1: error: no return statement in function returning non-void [-Werror=return-type] } ^ Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index 5cdfa71..b1b5721 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -882,6 +882,8 @@ static int dualsense_player_led_set_brightness(struct led_classdev *led, enum le spin_unlock_irqrestore(&ds->base.lock, flags); schedule_work(&ds->output_worker); + + return 0; } static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp,