From: Lukasz Pawelczyk <l.pawelczyk@samsung.com>
Date: Tue, 23 Jun 2020 12:27:00 +0000 (+0200)
Subject: Assert prime_len instead of error check
X-Git-Tag: submit/tizen/20200717.105954~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3c610ede0d8829b75cc6e583f23dd06ec5187d96;p=platform%2Fcore%2Fsecurity%2Fyaca.git

Assert prime_len instead of error check

It's impossible now that it'll be larger than INT_MAX. No need to
check that.

Change-Id: I64bd04d13a46430cef3e969e79b60e2fb8a77e1b
---

diff --git a/src/key.c b/src/key.c
index 17afc7c..68def62 100644
--- a/src/key.c
+++ b/src/key.c
@@ -1123,10 +1123,9 @@ static int generate_evp_pkey_params(int evp_id, size_t key_bit_len, EVP_PKEY **p
 			size_t gen_block = key_bit_len & YACA_KEYLEN_COMPONENT_DH_GEN_MASK;
 			size_t prime_len_block = key_bit_len & YACA_KEYLEN_COMPONENT_DH_PRIME_MASK;
 
-			/* This is impossible now as we take only 16 bits,
-			 * but for the sake of type safety */
-			if (prime_len_block > INT_MAX)
-				return YACA_ERROR_INVALID_PARAMETER;
+			/* This is impossible for now as we take only 16 bits
+			 * but just to be sure for the future */
+			assert(prime_len_block <= INT_MAX);
 			dh_prime_len = prime_len_block;
 
 			if (gen_block == YACA_KEYLEN_COMPONENT_DH_GEN_2)