From: Marcel Holtmann Date: Sun, 14 Jun 2009 13:24:44 +0000 (+0200) Subject: Bluetooth: Fix issue with uninitialized nsh.type in DTL-1 driver X-Git-Tag: v2.6.31-rc1~14^2~80 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3c4bdc4bd4af791a72147b6ebc29553808f53cea;p=profile%2Fivi%2Fkernel-x86-ivi.git Bluetooth: Fix issue with uninitialized nsh.type in DTL-1 driver The current build shows a warning with the DTL-1 driver: CC [M] drivers/bluetooth/dtl1_cs.o drivers/bluetooth/dtl1_cs.c: In function ‘dtl1_hci_send_frame’: drivers/bluetooth/dtl1_cs.c:396: warning: ‘nsh.type’ may be used uninitialized in this function Fix this by adding a proper error for unknown packet types. Signed-off-by: Marcel Holtmann --- diff --git a/drivers/bluetooth/dtl1_cs.c b/drivers/bluetooth/dtl1_cs.c index 901bdd9..2cc7b32 100644 --- a/drivers/bluetooth/dtl1_cs.c +++ b/drivers/bluetooth/dtl1_cs.c @@ -415,6 +415,8 @@ static int dtl1_hci_send_frame(struct sk_buff *skb) hdev->stat.sco_tx++; nsh.type = 0x83; break; + default: + return -EILSEQ; }; nsh.zero = 0;