From: Johan Jonker Date: Sun, 19 Mar 2023 15:02:18 +0000 (+0100) Subject: rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider X-Git-Tag: v2023.07~81^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3c4549771dd0352e893a0bc9d2344cd8ecd8033d;p=platform%2Fkernel%2Fu-boot.git rockchip: gpio: rk_gpio: use ROCKCHIP_GPIOS_PER_BANK as divider The current divider to calculate the bank ID can change. Given the Rockchip TRM not all gpio-banks have 32 pins per bank. The "gpio-ranges" syntax allows multiple items with variable number of pins. Use a constant ROCKCHIP_GPIOS_PER_BANK as fixed divider. Signed-off-by: Johan Jonker Reviewed-by: Simon Glass Reviewed-by: Kever Yang --- diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c index f7ad4d6..0a2acf1 100644 --- a/drivers/gpio/rk_gpio.c +++ b/drivers/gpio/rk_gpio.c @@ -160,7 +160,7 @@ static int rockchip_gpio_probe(struct udevice *dev) 0, &args); if (!ret || ret != -ENOENT) { uc_priv->gpio_count = args.args[2]; - priv->bank = args.args[1] / args.args[2]; + priv->bank = args.args[1] / ROCKCHIP_GPIOS_PER_BANK; } else { uc_priv->gpio_count = ROCKCHIP_GPIOS_PER_BANK; end = strrchr(dev->name, '@');