From: Luis de Bethencourt Date: Wed, 22 Jul 2015 15:10:35 +0000 (+0100) Subject: liveadder: remove unneeded variable X-Git-Tag: 1.6.0~319 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3bf12a1b9f04ba269cbed538269a454b3ecfa51b;p=platform%2Fupstream%2Fgst-plugins-bad.git liveadder: remove unneeded variable ret is declared just to initialize to TRUE and overwrite with the value of vret. We can return the value of vret directly. vret is TRUE unless the forward_event_func sets it to FALSE. --- diff --git a/gst/liveadder/liveadder.c b/gst/liveadder/liveadder.c index 12e4ace..1de6fe8 100644 --- a/gst/liveadder/liveadder.c +++ b/gst/liveadder/liveadder.c @@ -823,24 +823,19 @@ forward_event_func (const GValue * item, GValue * ret, gpointer user_data) static gboolean forward_event (GstLiveAdder * adder, GstEvent * event) { - gboolean ret; GstIterator *it; GValue vret = { 0 }; GST_LOG_OBJECT (adder, "Forwarding event %p (%s)", event, GST_EVENT_TYPE_NAME (event)); - ret = TRUE; - g_value_init (&vret, G_TYPE_BOOLEAN); g_value_set_boolean (&vret, TRUE); it = gst_element_iterate_sink_pads (GST_ELEMENT_CAST (adder)); gst_iterator_fold (it, forward_event_func, &vret, event); gst_iterator_free (it); - ret = g_value_get_boolean (&vret); - - return ret; + return g_value_get_boolean (&vret); }