From: David Walter Seikel Date: Tue, 24 Jan 2006 13:58:18 +0000 (+0000) Subject: When I cloned the pipe read stuff to make pipe error, I didn't realise that X-Git-Tag: submit/efl/20131021.015651~14104 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3bdc8d4c52193975d19bf3c9d0bc97a9dfc85310;p=platform%2Fupstream%2Fenlightenment.git When I cloned the pipe read stuff to make pipe error, I didn't realise that ECORE_FD_ERROR is not the stderr equivilant of ECORE_FD_READ. I just cloned, and changed READ's to ERROR's. imho ECORE_FD_ERROR is missnamed, and should at least be better documented. See man select_tut, especially the entry on exceptfds. SVN revision: 20006 --- diff --git a/src/bin/e_apps.c b/src/bin/e_apps.c index b374e86..9cbf1ab 100644 --- a/src/bin/e_apps.c +++ b/src/bin/e_apps.c @@ -1875,8 +1875,8 @@ _e_apps_cb_exit(void *data, int type, void *event) aut = E_NEW(E_App_Autopsy, 1); aut->app = a; aut->del = *ev; - aut->read = ecore_exe_event_data_get(ai->exe, ECORE_FD_READ); - aut->error = ecore_exe_event_data_get(ai->exe, ECORE_FD_ERROR); + aut->error = ecore_exe_event_data_get(ai->exe, ECORE_EXE_PIPE_ERROR); + aut->read = ecore_exe_event_data_get(ai->exe, ECORE_EXE_PIPE_READ); _e_app_error_dialog(NULL, aut); } if (ai->expire_timer) ecore_timer_del(ai->expire_timer);