From: Ming Lei <tom.leiming@gmail.com>
Date: Sat, 11 Jul 2009 03:11:10 +0000 (+0800)
Subject: driver core: firmware_class:fix memory leak of page pointers array
X-Git-Tag: upstream/snapshot3+hdmi~18009^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3b4418c67a70278964b063b5e1f56dcb3d0a41f3;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

driver core: firmware_class:fix memory leak of page pointers array

The page pointers array is allocated in fw_realloc_buffer() called by
firmware_data_write(), and should be freed in release function of firmware
device.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Reported-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index f285f44..7376367 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -180,7 +180,6 @@ static ssize_t firmware_loading_store(struct device *dev,
 				goto err;
 			}
 			/* Pages will be freed by vfree() */
-			fw_priv->pages = NULL;
 			fw_priv->page_array_size = 0;
 			fw_priv->nr_pages = 0;
 			complete(&fw_priv->completion);