From: Jan Schär Date: Mon, 9 Feb 2015 15:51:12 +0000 (+0100) Subject: test: Timeout#unref() does not return instance X-Git-Tag: v1.3.0~23 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3b1b4de9033e2dd167061692c31b9231368ccb81;p=platform%2Fupstream%2Fnodejs.git test: Timeout#unref() does not return instance Timeout#unref() call returns undefined, not this. The test already worked before, because the interval was still unref'd, and the test also succeeds without clearing the interval. PR-URL: https://github.com/joyent/node/pull/9171 Reviewed-by: Colin Ihrig Reviewed-by: Timothy J Fontaine Conflicts: test/simple/test-timers-unref.js --- diff --git a/test/parallel/test-timers-unref.js b/test/parallel/test-timers-unref.js index c4f9d82..9434dbb 100644 --- a/test/parallel/test-timers-unref.js +++ b/test/parallel/test-timers-unref.js @@ -21,7 +21,8 @@ setTimeout(function() { interval = setInterval(function() { unref_interval = true; clearInterval(interval); -}, SHORT_TIME).unref(); +}, SHORT_TIME); +interval.unref(); setTimeout(function() { unref_timer = true;