From: Stuart Henderson Date: Wed, 2 Oct 2019 08:42:40 +0000 (+0100) Subject: ASoC: wm_adsp: Don't generate kcontrols without READ flags X-Git-Tag: v5.4-rc6~21^2~9^2~8 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3ae7359c0e39f42a96284d6798fc669acff38140;p=platform%2Fkernel%2Flinux-rpi.git ASoC: wm_adsp: Don't generate kcontrols without READ flags User space always expects to be able to read ALSA controls, so ensure no kcontrols are generated without an appropriate READ flag. In the case of a read of such a control zeros will be returned. Signed-off-by: Stuart Henderson Signed-off-by: Charles Keepax Link: https://lore.kernel.org/r/20191002084240.21589-1-ckeepax@opensource.cirrus.com Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/wm_adsp.c b/sound/soc/codecs/wm_adsp.c index 85396d9..9b8bb7b 100644 --- a/sound/soc/codecs/wm_adsp.c +++ b/sound/soc/codecs/wm_adsp.c @@ -1259,8 +1259,7 @@ static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len) } if (in) { - if (in & WMFW_CTL_FLAG_READABLE) - out |= rd; + out |= rd; if (in & WMFW_CTL_FLAG_WRITEABLE) out |= wr; if (in & WMFW_CTL_FLAG_VOLATILE)