From: Chris Wilson <chris@chris-wilson.co.uk>
Date: Tue, 29 May 2018 16:28:07 +0000 (+0100)
Subject: i965: Only emit VF cache invalidations when the high bits changes
X-Git-Tag: upstream/19.0.0~4894
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3ac5fbadfd8644d30fce9ff267cb811ad157996a;p=platform%2Fupstream%2Fmesa.git

i965: Only emit VF cache invalidations when the high bits changes

Commit 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit
addressing bugs with softpin.") tried to only emit the VF invalidate if
the high bits changed, but it accidentally always set need_invalidate to
true; causing it to emit unconditionally emit the pipe control before
every primitive.

Fixes: 92f01fc5f914 ("i965: Emit VF cache invalidates for 48-bit addressing bugs with softpin.")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106708
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---

diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c
index b485e2c..88fde9d 100644
--- a/src/mesa/drivers/dri/i965/genX_state_upload.c
+++ b/src/mesa/drivers/dri/i965/genX_state_upload.c
@@ -504,7 +504,7 @@ static void
 vf_invalidate_for_vb_48bit_transitions(struct brw_context *brw)
 {
 #if GEN_GEN >= 8
-   bool need_invalidate = true;
+   bool need_invalidate = false;
    unsigned i;
 
    for (i = 0; i < brw->vb.nr_buffers; i++) {