From: Bryce W. Harrington <b.harrington@samsung.com>
Date: Tue, 14 Jan 2014 21:58:32 +0000 (+0000)
Subject: terminal: Only set title if asprintf succeeded
X-Git-Tag: upstream/0.1.8~506
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3abdafd12d67c2effa239c8e30415c24c162ec12;p=profile%2Fivi%2Fweston-ivi-shell.git

terminal: Only set title if asprintf succeeded

Handles potential out of memory situation by skipping the title update.
This fixes the following warning:

  terminal.c: In function ‘resize_handler’:
  terminal.c:851:11: warning: ignoring return value of ‘asprintf’,
  declared with attribute warn_unused_result [-Wunused-result]

Signed-off-by: Bryce Harrington <b.harrington@samsung.com>
---

diff --git a/clients/terminal.c b/clients/terminal.c
index e2a6236..09bc321 100644
--- a/clients/terminal.c
+++ b/clients/terminal.c
@@ -848,9 +848,10 @@ resize_handler(struct widget *widget,
 		width = columns * terminal->average_width + m;
 		height = rows * terminal->extents.height + m;
 		widget_set_size(terminal->widget, width, height);
-		asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows);
-		window_set_title(terminal->window, p);
-		free(p);
+		if (asprintf(&p, "%s — [%dx%d]", terminal->title, columns, rows) > 0) {
+		    window_set_title(terminal->window, p);
+		    free(p);
+		}
 	}
 
 	terminal_resize_cells(terminal, columns, rows);