From: Kenneth Graunke <kenneth@whitecape.org>
Date: Wed, 12 Dec 2018 09:52:23 +0000 (-0800)
Subject: iris: more dead comments
X-Git-Tag: upstream/19.3.0~8916
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3a938a4b2328499e0713495ae78125b4020d89f7;p=platform%2Fupstream%2Fmesa.git

iris: more dead comments
---

diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c
index ba8b60d..4b1a5d9 100644
--- a/src/gallium/drivers/iris/iris_program.c
+++ b/src/gallium/drivers/iris/iris_program.c
@@ -699,7 +699,6 @@ iris_setup_uniforms(const struct brw_compiler *compiler,
 
    nir_validate_shader(nir, "after remap");
 
-   // XXX: vs clip planes?
    if (nir->info.stage != MESA_SHADER_COMPUTE)
       brw_nir_analyze_ubo_ranges(compiler, nir, NULL, prog_data->ubo_ranges);
 
diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c
index 4c95d6d..a2fef71 100644
--- a/src/gallium/drivers/iris/iris_state.c
+++ b/src/gallium/drivers/iris/iris_state.c
@@ -2852,8 +2852,6 @@ iris_emit_sbe_swiz(struct iris_batch *batch,
 
    /* XXX: this should be generated when putting programs in place */
 
-   // XXX: raster->sprite_coord_enable
-
    for (int fs_attr = 0; fs_attr < VARYING_SLOT_MAX; fs_attr++) {
       const int input_index = wm_prog_data->urb_setup[fs_attr];
       if (input_index < 0 || input_index >= 16)
@@ -3047,7 +3045,6 @@ static void
 iris_populate_fs_key(const struct iris_context *ice,
                      struct brw_wm_prog_key *key)
 {
-   /* XXX: dirty flags? */
    const struct pipe_framebuffer_state *fb = &ice->state.framebuffer;
    const struct iris_depth_stencil_alpha_state *zsa = ice->state.cso_zsa;
    const struct iris_rasterizer_state *rast = ice->state.cso_rast;
@@ -3068,8 +3065,6 @@ iris_populate_fs_key(const struct iris_context *ice,
 
    key->coherent_fb_fetch = true;
 
-   // XXX: uint64_t input_slots_valid; - for >16 inputs
-
    // XXX: key->force_dual_color_blend for unigine
    // XXX: respect hint for high_quality_derivatives:1;
 }
@@ -3724,8 +3719,6 @@ iris_restore_render_saved_bos(struct iris_context *ice,
 {
    struct iris_genx_state *genx = ice->state.genx;
 
-   // XXX: whack IRIS_SHADER_DIRTY_BINDING_TABLE on new batch
-
    const uint64_t clean = ~ice->state.dirty;
 
    if (clean & IRIS_DIRTY_CC_VIEWPORT) {
@@ -4027,9 +4020,6 @@ iris_upload_dirty_render_state(struct iris_context *ice,
       }
    }
 
-   /* XXX: L3 State */
-
-   // XXX: this is only flagged at setup, we assume a static configuration
    if (dirty & IRIS_DIRTY_URB) {
       iris_upload_urb_config(ice, batch);
    }
@@ -4316,7 +4306,6 @@ iris_upload_dirty_render_state(struct iris_context *ice,
 
    }
 
-   /* XXX: FS program updates needs to flag IRIS_DIRTY_WM */
    if (dirty & IRIS_DIRTY_WM) {
       struct iris_rasterizer_state *cso = ice->state.cso_rast;
       uint32_t dynamic_wm[GENX(3DSTATE_WM_length)];