From: Wolfram Sang Date: Tue, 23 Mar 2010 20:35:18 +0000 (-0700) Subject: get_maintainer: repair STDIN usage X-Git-Tag: v2.6.34-rc3~73 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3a4df13d2420ae1998e5c7d26275f8714e84da30;p=platform%2Fkernel%2Flinux-3.10.git get_maintainer: repair STDIN usage Commit 22dd5b0cba50a197aaa3bd2790a29ee2e8e4e372 (fix perlcritic warnings) broke the ability to handle STDIN because the three argument version of open() cannot handle standard IO-streams (which is mentioned in PerlBestPractices, too). Signed-off-by: Wolfram Sang Cc: Stephen Hemminger Acked-by: Joe Perches Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index f76f3d1..6f97a13 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -284,7 +284,7 @@ foreach my $file (@ARGV) { my $file_cnt = @files; my $lastfile; - open(my $patch, '<', $file) + open(my $patch, "< $file") or die "$P: Can't open $file: $!\n"; while (<$patch>) { my $patch_line = $_;