From: Julian Lettner Date: Tue, 2 Apr 2019 18:46:59 +0000 (+0000) Subject: [NFC][libdispatch] Improve a few tests X-Git-Tag: llvmorg-10-init~8656 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3a23fb1e04e0d9d2fbfe5aa7947954c57b977c3e;p=platform%2Fupstream%2Fllvm.git [NFC][libdispatch] Improve a few tests llvm-svn: 357510 --- diff --git a/compiler-rt/test/tsan/libdispatch/apply.c b/compiler-rt/test/tsan/libdispatch/apply.c index d361169..08735b3 100644 --- a/compiler-rt/test/tsan/libdispatch/apply.c +++ b/compiler-rt/test/tsan/libdispatch/apply.c @@ -55,4 +55,3 @@ int main(int argc, const char *argv[]) { // CHECK: array[0] = 142 // CHECK: array[1] = 143 // CHECK: done -// CHECK-NOT: WARNING: ThreadSanitizer diff --git a/compiler-rt/test/tsan/libdispatch/data.c b/compiler-rt/test/tsan/libdispatch/data.c index 7a6975b..dd71b1f 100644 --- a/compiler-rt/test/tsan/libdispatch/data.c +++ b/compiler-rt/test/tsan/libdispatch/data.c @@ -1,5 +1,5 @@ // RUN: %clang_tsan %s -o %t -// RUN: %run %t 2>&1 | FileCheck %s +// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer' // TODO(yln): fails on one of our bots, need to investigate // REQUIRES: disabled @@ -37,5 +37,4 @@ int main(int argc, const char *argv[]) { // CHECK: Hello world. // CHECK: Data destructor. -// CHECK-NOT: WARNING: ThreadSanitizer // CHECK: Done. diff --git a/compiler-rt/test/tsan/libdispatch/source-serial.c b/compiler-rt/test/tsan/libdispatch/source-serial.c index 79dc1af..7096396 100644 --- a/compiler-rt/test/tsan/libdispatch/source-serial.c +++ b/compiler-rt/test/tsan/libdispatch/source-serial.c @@ -1,5 +1,5 @@ // RUN: %clang_tsan %s -o %t -// RUN: %run %t 2>&1 | FileCheck %s +// RUN: %run %t 2>&1 | FileCheck %s --implicit-check-not='ThreadSanitizer' // TODO(yln): fails on one of our bots, need to investigate // REQUIRES: disabled @@ -14,16 +14,18 @@ int main(int argc, const char *argv[]) { fprintf(stderr, "Hello world.\n"); dispatch_queue_t q = dispatch_queue_create("my.queue", DISPATCH_QUEUE_SERIAL); - dispatch_semaphore_t sem = dispatch_semaphore_create(0); dispatch_source_t timer = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, q); long long interval_ms = 10; dispatch_source_set_timer(timer, dispatch_time(DISPATCH_TIME_NOW, 0), interval_ms * NSEC_PER_MSEC, 0); + + dispatch_semaphore_t sem = dispatch_semaphore_create(0); dispatch_source_set_event_handler(timer, ^{ fprintf(stderr, "timer\n"); global++; if (global > 50) { dispatch_semaphore_signal(sem); + dispatch_suspend(timer); } }); dispatch_resume(timer); @@ -34,5 +36,6 @@ int main(int argc, const char *argv[]) { } // CHECK: Hello world. -// CHECK-NOT: WARNING: ThreadSanitizer +// CHECK: timer // CHECK: Done. +// CHECK-NOT: timer