From: Jason McDonald <jason.mcdonald@nokia.com>
Date: Wed, 24 Aug 2011 08:20:44 +0000 (+1000)
Subject: Add missing assertions.
X-Git-Tag: qt-v5.0.0-alpha1~3748
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=39f9fd29526ae8f6803314d9fdc8dcf1cb9bd2bc;p=profile%2Fivi%2Fqtbase.git

Add missing assertions.

For both QTestLog::addFail() and QTestLog::addIgnoreMessage(), passing
a null message does not make sense and is therefore an error that
should be brought to the developer's attention.

Change-Id: Ib09ad90b70d74f7432c08708db8a70dee008cce4
Reviewed-on: http://codereview.qt.nokia.com/3470
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
---

diff --git a/src/testlib/qtestlog.cpp b/src/testlib/qtestlog.cpp
index 855f8fd..9990bbd 100644
--- a/src/testlib/qtestlog.cpp
+++ b/src/testlib/qtestlog.cpp
@@ -251,6 +251,7 @@ void QTestLog::addPass(const char *msg)
 void QTestLog::addFail(const char *msg, const char *file, int line)
 {
     QTEST_ASSERT(QTest::testLogger);
+    QTEST_ASSERT(msg);
 
     QTest::testLogger->addIncident(QAbstractTestLogger::Fail, msg, file, line);
 }
@@ -353,6 +354,8 @@ int QTestLog::verboseLevel()
 
 void QTestLog::addIgnoreMessage(QtMsgType type, const char *msg)
 {
+    QTEST_ASSERT(msg);
+
     QTest::IgnoreResultList *item = new QTest::IgnoreResultList(type, msg);
 
     QTest::IgnoreResultList *list = QTest::ignoreResultList;