From: Rafal Walczyna Date: Tue, 27 Mar 2018 11:55:44 +0000 (+0200) Subject: [common] Fixing coverity issues X-Git-Tag: submit/tizen/20180403.060641~1^2~1^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=398a65abe664ff9505250d87f7aa820b902bd32c;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git [common] Fixing coverity issues Issues: 110672, 108789, 108137, 107617, 106435, 112265, 112254, 107669, 105923 [Verification] 100% passrate in: bookmark, calendar, contact, content, datacontrol, filesystem, keymanager Change-Id: Id667a94fe653f831a8cfdd70813c8ace91e1cf5d Signed-off-by: Rafal Walczyna --- diff --git a/src/bookmark/bookmark_instance.cc b/src/bookmark/bookmark_instance.cc index 884dba14..145d6b4e 100644 --- a/src/bookmark/bookmark_instance.cc +++ b/src/bookmark/bookmark_instance.cc @@ -70,7 +70,11 @@ bool BookmarkInstance::bookmark_foreach(Context& ctx, bp_bookmark_info_fmt& info if (ids_count > 0) { for (int i = 0; i < ids_count; i++) { - bp_bookmark_adaptor_get_easy_all(ids[i], &info); + if (bp_bookmark_adaptor_get_easy_all(ids[i], &info) < 0) { + int errorcode = bp_bookmark_adaptor_get_errorcode(); + LoggerW("bp_bookmark_adaptor_get_easy_all for id %d returns error: %d", ids[i], errorcode); + continue; + } item.id = ids[i]; item.bookmark_info = info; if ((ctx.shouldGetItems && item.bookmark_info.parent != ctx.id) || diff --git a/src/calendar/calendar_manager.cc b/src/calendar/calendar_manager.cc index db72589a..16066357 100644 --- a/src/calendar/calendar_manager.cc +++ b/src/calendar/calendar_manager.cc @@ -36,7 +36,7 @@ const int kUnifiedCalendardId = 0; using namespace common; -CalendarManager::CalendarManager() { +CalendarManager::CalendarManager() : is_connected_(false) { ScopeLogger(); if (CALENDAR_ERROR_NONE == calendar_connect()) { LoggerD("Calendar DB connected"); diff --git a/src/contact/contact_manager.cc b/src/contact/contact_manager.cc index 6fe6b982..7730068d 100644 --- a/src/contact/contact_manager.cc +++ b/src/contact/contact_manager.cc @@ -106,7 +106,11 @@ PlatformResult ContactManagerGetAddressBooks(const JsonObject& args, JsonArray& single_obj["readOnly"] = JsonValue(CONTACTS_ADDRESS_BOOK_MODE_READONLY == mode); out.push_back(single); - contacts_list_next(*contacts_list_ptr); + error_code = contacts_list_next(*contacts_list_ptr); + if (CONTACTS_ERROR_NONE != error_code) { + LoggerW("contacts_list_next() failed: %d, ignoring remaining contacts", error_code); + break; + } } return PlatformResult(ErrorCode::NO_ERROR); @@ -771,7 +775,11 @@ PlatformResult ContactManagerFind(const JsonObject& args, JsonArray& out) { out.push_back(JsonValue(obj)); - contacts_list_next(person_list); + error_code = contacts_list_next(person_list); + if (CONTACTS_ERROR_NONE != error_code) { + LoggerW("contacts_list_next() failed: %d, ignoring remaining contacts", error_code); + break; + } } return PlatformResult(ErrorCode::NO_ERROR); @@ -954,7 +962,11 @@ PlatformResult ContactManagerFindByUsageCount(const JsonObject& args, JsonArray& out.push_back(JsonValue(obj)); - contacts_list_next(person_list); + error_code = contacts_list_next(person_list); + if (CONTACTS_ERROR_NONE != error_code) { + LoggerW("contacts_list_next() failed: %d, ignoring remaining contacts", error_code); + break; + } } return PlatformResult(ErrorCode::NO_ERROR); diff --git a/src/contact/person.cc b/src/contact/person.cc index 909d221a..136407ea 100644 --- a/src/contact/person.cc +++ b/src/contact/person.cc @@ -246,7 +246,11 @@ PlatformResult GetUsageCount(const JsonObject& args, JsonObject& out) { usage_count += usage_count_tmp; - contacts_list_next(list); + ret = contacts_list_next(list); + if (CONTACTS_ERROR_NONE != ret) { + LoggerW("contacts_list_next() failed: %d, ignoring remaining contacts", ret); + break; + } } out.insert( diff --git a/src/content/content_manager.cc b/src/content/content_manager.cc index ab888871..edd86d51 100644 --- a/src/content/content_manager.cc +++ b/src/content/content_manager.cc @@ -1383,7 +1383,10 @@ int ContentManager::getLyrics(const picojson::value& args, picojson::object& res } metadata_extractor_h extractor; - metadata_extractor_create(&extractor); + ret = metadata_extractor_create(&extractor); + if (METADATA_EXTRACTOR_ERROR_NONE != ret) { + LOGGER(ERROR) << "metadata_extractor_create failed, error: " << ret; + } std::unique_ptr::type, int (*)(metadata_extractor_h)> extractor_ptr(extractor, &metadata_extractor_destroy); // automatically release the memory diff --git a/src/datacontrol/datacontrol_instance.cc b/src/datacontrol/datacontrol_instance.cc index 97c3720e..00a41e38 100644 --- a/src/datacontrol/datacontrol_instance.cc +++ b/src/datacontrol/datacontrol_instance.cc @@ -413,9 +413,7 @@ int DatacontrolInstance::RunMAPDataControlJob(const std::string& providerId, result = job(handle, &info->requestId); RETURN_IF_FAIL(result, "Doing job failed with error"); - IdMap[info->requestId] = info.get(); - - info.release(); + IdMap[info->requestId] = info.release(); return result; } @@ -448,9 +446,7 @@ int DatacontrolInstance::RunSQLDataControlJob(const std::string& providerId, result = job(handle, &info->requestId); RETURN_IF_FAIL(result, "Doing job failed with error"); - IdMap[info->requestId] = info.get(); - - info.release(); + IdMap[info->requestId] = info.release(); return result; } diff --git a/src/filesystem/filesystem_manager.cc b/src/filesystem/filesystem_manager.cc index e6b373d2..5050a0ae 100644 --- a/src/filesystem/filesystem_manager.cc +++ b/src/filesystem/filesystem_manager.cc @@ -460,6 +460,7 @@ void FilesystemManager::GetCanonicalPath(const std::string& path, LoggerE("Cannot get realpath of %s. Error: %s!", path.c_str(), GetErrorString(tmpErrno).c_str()); error_cb(FilesystemError::Other); + return; } std::string canonicalPathStr(canonicalPath); diff --git a/src/keymanager/keymanager_instance.cc b/src/keymanager/keymanager_instance.cc index 0e055122..cc85aad8 100644 --- a/src/keymanager/keymanager_instance.cc +++ b/src/keymanager/keymanager_instance.cc @@ -64,9 +64,13 @@ void GetGenericAliasList(AliasListFunction func, picojson::object* out) { if (head->alias) { char* saveptr = nullptr; char* tokenized = strtok_r(head->alias, kSpace.c_str(), &saveptr); - obj["packageId"] = picojson::value(tokenized); + if (nullptr != tokenized) { + obj["packageId"] = picojson::value(tokenized); + } tokenized = strtok_r(nullptr, kSpace.c_str(), &saveptr); - obj["name"] = picojson::value(tokenized); + if (nullptr != tokenized) { + obj["name"] = picojson::value(tokenized); + } aliases.push_back(resultElem); }