From: Tim-Philipp Müller Date: Wed, 22 Aug 2012 08:20:55 +0000 (+0100) Subject: rtp: fix buffer leak when gst_rtp_buffer_map() fails because of broken data X-Git-Tag: RELEASE-0.11.94~102 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=392d3225ce520505751dd8c8c19de2ca892804e0;p=platform%2Fupstream%2Fgst-plugins-base.git rtp: fix buffer leak when gst_rtp_buffer_map() fails because of broken data Makes libs/rtp unit test valgrind clean. --- diff --git a/gst-libs/gst/rtp/gstrtpbuffer.c b/gst-libs/gst/rtp/gstrtpbuffer.c index 86fc808..f6f8bcc 100644 --- a/gst-libs/gst/rtp/gstrtpbuffer.c +++ b/gst-libs/gst/rtp/gstrtpbuffer.c @@ -443,7 +443,14 @@ wrong_padding: } dump_packet: { + gint i; + GST_MEMDUMP ("buffer", data, size); + + for (i = 0; i < G_N_ELEMENTS (rtp->map); ++i) { + if (rtp->data[i] != NULL) + gst_buffer_unmap (buffer, &rtp->map[i]); + } return FALSE; } }