From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 25 Jun 2021 14:58:54 +0000 (+0300)
Subject: mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()
X-Git-Tag: v6.1-rc5~2768^2~121^2^2~151
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3924715ffe5e064a85f56490f77b7b2084230800;p=platform%2Fkernel%2Flinux-starfive.git

mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()

Zero out all the unused members of "req" so that we don't disclose
stack information.

Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index 4396077..dfb6f17 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -3481,7 +3481,7 @@ static int mt7915_mcu_set_pre_cal(struct mt7915_dev *dev, u8 idx,
 		u8 idx;
 		u8 rsv[4];
 		__le32 len;
-	} req;
+	} req = {};
 	struct sk_buff *skb;
 
 	skb = mt76_mcu_msg_alloc(&dev->mt76, NULL, sizeof(req) + len);