From: Wang Ming Date: Wed, 26 Jul 2023 11:45:45 +0000 (+0800) Subject: reset: hisilicon: Use dev_err_probe instead of dev_err X-Git-Tag: v6.6.17~4069^2~16^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=38d09b989721ad14cbbeb82a28c1c6978438bcce;p=platform%2Fkernel%2Flinux-rpi.git reset: hisilicon: Use dev_err_probe instead of dev_err The probe process may generate EPROBE_DEFER. In this case, dev_err_probe can still record err information. This helps simplify code and standardize error output. Signed-off-by: Wang Ming Link: https://lore.kernel.org/r/20230726114555.5011-1-machel@vivo.com Signed-off-by: Philipp Zabel --- diff --git a/drivers/reset/hisilicon/reset-hi3660.c b/drivers/reset/hisilicon/reset-hi3660.c index 087f28e326ee..1beb275275ad 100644 --- a/drivers/reset/hisilicon/reset-hi3660.c +++ b/drivers/reset/hisilicon/reset-hi3660.c @@ -90,8 +90,8 @@ static int hi3660_reset_probe(struct platform_device *pdev) "hisi,rst-syscon"); } if (IS_ERR(rc->map)) { - dev_err(dev, "failed to get hisilicon,rst-syscon\n"); - return PTR_ERR(rc->map); + return dev_err_probe(dev, PTR_ERR(rc->map), + "failed to get hisilicon,rst-syscon\n"); } rc->rst.ops = &hi3660_reset_ops,