From: Tim-Philipp Müller <tim@centricular.com>
Date: Sat, 4 Jun 2016 12:11:55 +0000 (+0100)
Subject: element: remove base_class_finalize_func which is never called
X-Git-Tag: 1.10.4~224
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=38c74e41c7a1957e6fcb19b105a58d8c0196025c;p=platform%2Fupstream%2Fgstreamer.git

element: remove base_class_finalize_func which is never called

Won't be called for static types, so no point keeping it around.

https://bugzilla.gnome.org/show_bug.cgi?id=765540
---

diff --git a/gst/gstelement.c b/gst/gstelement.c
index 0b204f9..dd1f9dc 100644
--- a/gst/gstelement.c
+++ b/gst/gstelement.c
@@ -118,7 +118,6 @@ enum
 static void gst_element_class_init (GstElementClass * klass);
 static void gst_element_init (GstElement * element);
 static void gst_element_base_class_init (gpointer g_class);
-static void gst_element_base_class_finalize (gpointer g_class);
 
 static void gst_element_constructed (GObject * object);
 static void gst_element_dispose (GObject * object);
@@ -167,7 +166,7 @@ gst_element_get_type (void)
     static const GTypeInfo element_info = {
       sizeof (GstElementClass),
       gst_element_base_class_init,
-      gst_element_base_class_finalize,
+      NULL,                     /* base_class_finalize */
       (GClassInitFunc) gst_element_class_init,
       NULL,
       NULL,
@@ -296,17 +295,6 @@ gst_element_base_class_init (gpointer g_class)
 }
 
 static void
-gst_element_base_class_finalize (gpointer g_class)
-{
-  GstElementClass *klass = GST_ELEMENT_CLASS (g_class);
-
-  g_list_foreach (klass->padtemplates, (GFunc) gst_object_unref, NULL);
-  g_list_free (klass->padtemplates);
-
-  gst_structure_free (klass->metadata);
-}
-
-static void
 gst_element_init (GstElement * element)
 {
   GST_STATE (element) = GST_STATE_NULL;