From: Thomas Preud'homme <thomas.preudhomme@arm.com>
Date: Thu, 7 Dec 2017 21:48:35 +0000 (+0000)
Subject: Improve fstack_protector effective target
X-Git-Tag: upstream/12.2.0~34996
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=38b28c6eb28463feadfc7e18d553f8f2327a2219;p=platform%2Fupstream%2Fgcc.git

Improve fstack_protector effective target

Effective target fstack_protector fails to return an error for
newlib-based target (such as arm-none-eabi targets) which does not
support stack protector. This is due to the test being too simplist for
stack protection code to be generated by GCC: it does not contain a
local buffer and does not read unknown input.

This commit adds a small local buffer with a copy of the filename to
trigger stack protector code to be generated. The filename is used
instead of the full path so as to ensure the size will fit in the local
buffer.

2017-12-07  Thomas Preud'homme  <thomas.preudhomme@arm.com>

    gcc/testsuite/
    * lib/target-supports.exp (check_effective_target_fstack_protector):
    Copy filename in local buffer to trigger stack protection.

From-SVN: r255484
---

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index dab24f4..9f8e837 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2017-12-07  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+	* lib/target-supports.exp (check_effective_target_fstack_protector):
+	Copy filename in local buffer to trigger stack protection.
+
 2017-12-07  Joseph Myers  <joseph@codesourcery.com>
 
 	* gcc.dg/c11-align-7.c, gcc.dg/c11-align-8.c,
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index 6242ce9..ed7d624 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -1064,7 +1064,11 @@ proc check_effective_target_static {} {
 # Return 1 if the target supports -fstack-protector
 proc check_effective_target_fstack_protector {} {
     return [check_runtime fstack_protector {
-	int main (void) { return 0; }
+	#include <string.h>
+	int main (int argc, char *argv[]) {
+	  char buf[64];
+	  return !strcpy (buf, strrchr (argv[0], '/'));
+	}
     } "-fstack-protector"]
 }