From: Dan Carpenter Date: Mon, 8 Aug 2011 21:06:44 +0000 (-0700) Subject: iscsi-target: forever loop bug in iscsit_attach_ooo_cmdsn() X-Git-Tag: v3.1-rc4~43^2~14 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=387e96c05299ca7a0ade874f343f91f0b01086a0;p=profile%2Fivi%2Fkernel-x86-ivi.git iscsi-target: forever loop bug in iscsit_attach_ooo_cmdsn() This patch fixes a forever loop bug in iscsit_attach_ooo_cmdsn() while walking sess->sess_ooo_cmdsn_list when the received CmdSN is less than the tail of the list. Signed-off-by: Dan Carpenter Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/iscsi/iscsi_target_erl1.c b/drivers/target/iscsi/iscsi_target_erl1.c index 9806507..c4c68da 100644 --- a/drivers/target/iscsi/iscsi_target_erl1.c +++ b/drivers/target/iscsi/iscsi_target_erl1.c @@ -834,7 +834,7 @@ static int iscsit_attach_ooo_cmdsn( */ list_for_each_entry(ooo_tmp, &sess->sess_ooo_cmdsn_list, ooo_list) { - while (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn) + if (ooo_tmp->cmdsn < ooo_cmdsn->cmdsn) continue; list_add(&ooo_cmdsn->ooo_list,