From: Mauro Carvalho Chehab Date: Sun, 3 Mar 2013 12:34:41 +0000 (-0300) Subject: [media] em28xx-dvb: Don't put device in suspend mode at feed stop X-Git-Tag: v3.10-rc1~136^2~639 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=385cd33c8dcac5a166c2d034169427e263bf4608;p=platform%2Fupstream%2Fkernel-adaptation-pc.git [media] em28xx-dvb: Don't put device in suspend mode at feed stop Putting em28xx in suspend mode when a feed stops is just plain wrong. Every time a new PES filter is changed, the DVB demux code will stop the current feed, and then start a new one. If are there any code that switches off the frontend, via some GPIO setting, this would make the DVB fail. This condition was actually trigged with one device, during DVB scan, as, during scan, it is common that userspace apps to change the filter several times, in order to get all tables. Also, this is not needed at all, since the em28xx code already hooks into ops.ts_bus_ctrl(). This warrants that em28xx can check there if DVB frontend is in usage or not. The code there already puts the device on suspend mode, if the DVB frontend is not used (closed). Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c index a81ec2e..7200dfe 100644 --- a/drivers/media/usb/em28xx/em28xx-dvb.c +++ b/drivers/media/usb/em28xx/em28xx-dvb.c @@ -220,8 +220,6 @@ static int em28xx_stop_streaming(struct em28xx_dvb *dvb) em28xx_stop_urbs(dev); - em28xx_set_mode(dev, EM28XX_SUSPEND); - return 0; }