From: Felipe Balbi Date: Mon, 26 Mar 2018 10:26:00 +0000 (+0300) Subject: usb: dwc3: gadget: XferNotReady is Isoc-only X-Git-Tag: v4.19~894^2~81^2~59 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=38408464aa7646e4d7b345a70951f968af35af0a;p=platform%2Fkernel%2Flinux-rpi.git usb: dwc3: gadget: XferNotReady is Isoc-only We don't use XferNotReady for anything other than Default Control Pipe, which is handled in ep0.c, and Isochronous endpoints. Let's make that clear in the code. Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index 36fabde..22c0822 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -2533,11 +2533,13 @@ static void dwc3_endpoint_interrupt(struct dwc3 *dwc, dwc3_endpoint_transfer_complete(dwc, dep, event); break; case DWC3_DEPEVT_XFERNOTREADY: - if (usb_endpoint_xfer_isoc(dep->endpoint.desc)) - dwc3_gadget_start_isoc(dwc, dep, event); - else - __dwc3_gadget_kick_transfer(dep); + if (!usb_endpoint_xfer_isoc(dep->endpoint.desc)) { + dev_err(dwc->dev, "XferNotReady for non-Isoc %s\n", + dep->name); + return; + } + dwc3_gadget_start_isoc(dwc, dep, event); break; case DWC3_DEPEVT_STREAMEVT: if (!usb_endpoint_xfer_bulk(dep->endpoint.desc)) {