From: Thibault Saunier Date: Tue, 23 Jul 2013 14:13:06 +0000 (-0400) Subject: qa: Properly set reporter's runner reference X-Git-Tag: 1.19.3~491^2~2580 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=382fcc9a01521dcb544add878677d7ad27a9e431;p=platform%2Fupstream%2Fgstreamer.git qa: Properly set reporter's runner reference That was never set, but it is needed for the reporter to properly add reports to the runner. We still keep a reference on the monitor to make things simpler --- diff --git a/validate/gst/qa/gst-qa-monitor.c b/validate/gst/qa/gst-qa-monitor.c index 3259b32bc5..0a543610b3 100644 --- a/validate/gst/qa/gst-qa-monitor.c +++ b/validate/gst/qa/gst-qa-monitor.c @@ -196,6 +196,7 @@ gst_qa_monitor_set_property (GObject * object, guint prop_id, /* we assume the runner is valid as long as this monitor is, * no ref taken */ monitor->runner = g_value_get_object (value); + gst_qa_reporter_set_runner (GST_QA_REPORTER (monitor), monitor->runner); break; case PROP_QA_PARENT: monitor->parent = g_value_get_object (value); diff --git a/validate/gst/qa/gst-qa-reporter.c b/validate/gst/qa/gst-qa-reporter.c index 85f4fdd8c9..472e4d3bd8 100644 --- a/validate/gst/qa/gst-qa-reporter.c +++ b/validate/gst/qa/gst-qa-reporter.c @@ -155,3 +155,11 @@ gst_qa_reporter_get_runner (GstQaReporter * reporter) return priv->runner; } + +void +gst_qa_reporter_set_runner (GstQaReporter * reporter, GstQaRunner * runner) +{ + GstQaReporterPrivate *priv = gst_qa_reporter_get_priv (reporter); + + priv->runner = runner; +} diff --git a/validate/gst/qa/gst-qa-reporter.h b/validate/gst/qa/gst-qa-reporter.h index 6991bf2ff5..b45601ca81 100644 --- a/validate/gst/qa/gst-qa-reporter.h +++ b/validate/gst/qa/gst-qa-reporter.h @@ -103,8 +103,8 @@ void gst_qa_report_valist (GstQaReporter * reporter, gboolean rep GstQaReportLevel level, GstQaReportArea area, gint subarea, const gchar * format, va_list var_args); +void gst_qa_reporter_set_runner (GstQaReporter * reporter, + GstQaRunner *runner); + G_END_DECLS #endif /* _GST_QA_REPORTER_ */ - - - diff --git a/validate/gst/qa/gst-qa-scenario.c b/validate/gst/qa/gst-qa-scenario.c index e9c5b56b98..cafb47dfe3 100644 --- a/validate/gst/qa/gst-qa-scenario.c +++ b/validate/gst/qa/gst-qa-scenario.c @@ -374,13 +374,12 @@ static void gst_qa_scenario_set_property (GObject * object, guint prop_id, const GValue * value, GParamSpec * pspec) { - GstQaScenarioPrivate *priv = GST_QA_SCENARIO (object)->priv; - switch (prop_id) { case PROP_RUNNER: /* we assume the runner is valid as long as this scenario is, * no ref taken */ - priv->runner = g_value_get_object (value); + gst_qa_reporter_set_runner (GST_QA_REPORTER (object), + g_value_get_object (value)); break; default: break; @@ -391,13 +390,12 @@ static void gst_qa_scenario_get_property (GObject * object, guint prop_id, GValue * value, GParamSpec * pspec) { - GstQaScenarioPrivate *priv = GST_QA_SCENARIO (object)->priv; - switch (prop_id) { case PROP_RUNNER: /* we assume the runner is valid as long as this scenario is, * no ref taken */ - g_value_set_object (value, priv->runner); + g_value_set_object (value, + gst_qa_reporter_get_runner (GST_QA_REPORTER (object))); break; default: break;