From: Levente Kurusa Date: Thu, 19 Dec 2013 15:06:49 +0000 (-0300) Subject: [media] media: bt8xx: add missing put_device call X-Git-Tag: v3.14-rc2~14^2~12 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=38121b6ef314e556d3b59acc0c41a4d6f7e597fa;p=kernel%2Fkernel-generic.git [media] media: bt8xx: add missing put_device call This is required so that we give up the last reference to the device. Remove the kfree() because the put_device() call will actually call release_sub_device which in turn kfrees the device. Signed-off-by: Levente Kurusa Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/pci/bt8xx/bttv-gpio.c b/drivers/media/pci/bt8xx/bttv-gpio.c index 922e823..3f364b7 100644 --- a/drivers/media/pci/bt8xx/bttv-gpio.c +++ b/drivers/media/pci/bt8xx/bttv-gpio.c @@ -98,7 +98,7 @@ int bttv_sub_add_device(struct bttv_core *core, char *name) err = device_register(&sub->dev); if (0 != err) { - kfree(sub); + put_device(&sub->dev); return err; } pr_info("%d: add subdevice \"%s\"\n", core->nr, dev_name(&sub->dev));