From: Jesper Juhl Date: Mon, 13 Jun 2011 21:52:02 +0000 (+0200) Subject: ALSA: 6fire: Fix double-free bug in usb6fire_fw_ezusb_upload() X-Git-Tag: upstream/snapshot3+hdmi~8798^2~150 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=37f7ec38ea5c31180461f82e895e13fdd549b595;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git ALSA: 6fire: Fix double-free bug in usb6fire_fw_ezusb_upload() We have a double-free bug in sound/usb/6fire/firmware.c::usb6fire_fw_ezusb_upload(). We already call release_firmware(fw) on line 258, so when we then do it again after usb6fire_fw_ezusb_write() returns <0, we have a double-free. Easily fixed by just removing the last call to release_firmware(). Signed-off-by: Jesper Juhl Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/6fire/firmware.c b/sound/usb/6fire/firmware.c index a91719d..1e3ae33 100644 --- a/sound/usb/6fire/firmware.c +++ b/sound/usb/6fire/firmware.c @@ -270,7 +270,6 @@ static int usb6fire_fw_ezusb_upload( data = 0x00; /* resume ezusb cpu */ ret = usb6fire_fw_ezusb_write(device, 0xa0, 0xe600, &data, 1); if (ret < 0) { - release_firmware(fw); snd_printk(KERN_ERR PREFIX "unable to upload ezusb " "firmware %s: end message.\n", fwname); return ret;