From: Antti Palosaari Date: Sat, 14 May 2016 05:29:21 +0000 (-0300) Subject: [media] mn88473: fix error path on probe() X-Git-Tag: v5.15~13214^2~287 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=37cf9b2d5b0fdeb61642e15ad30251f1371e25d5;p=platform%2Fkernel%2Flinux-starfive.git [media] mn88473: fix error path on probe() Latest, 3rd, regmap instance should be freed on error case. Signed-off-by: Antti Palosaari Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/dvb-frontends/mn88473.c b/drivers/media/dvb-frontends/mn88473.c index 6c5d5921..e6933d4 100644 --- a/drivers/media/dvb-frontends/mn88473.c +++ b/drivers/media/dvb-frontends/mn88473.c @@ -536,7 +536,7 @@ static int mn88473_probe(struct i2c_client *client, /* Sleep because chip is active by default */ ret = regmap_write(dev->regmap[2], 0x05, 0x3e); if (ret) - goto err_client_2_i2c_unregister_device; + goto err_regmap_2_regmap_exit; /* Create dvb frontend */ memcpy(&dev->frontend.ops, &mn88473_ops, sizeof(dev->frontend.ops)); @@ -547,7 +547,8 @@ static int mn88473_probe(struct i2c_client *client, dev_info(&client->dev, "Panasonic MN88473 successfully identified\n"); return 0; - +err_regmap_2_regmap_exit: + regmap_exit(dev->regmap[2]); err_client_2_i2c_unregister_device: i2c_unregister_device(dev->client[2]); err_regmap_1_regmap_exit: