From: Dan Carpenter Date: Tue, 12 Nov 2013 12:34:11 +0000 (+0100) Subject: drm/nvc0-/gr: shift wrapping bug in nvc0_grctx_generate_r406800 X-Git-Tag: v3.13-rc8~13^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=377cfdc6eeced55e220fea2d07d6ebdd32166e66;p=platform%2Fkernel%2Flinux-stable.git drm/nvc0-/gr: shift wrapping bug in nvc0_grctx_generate_r406800 We care about the upper 32 bits here so we have to use 1ULL instead of 1 to avoid a shift wrapping bug. Signed-off-by: Dan Carpenter Signed-off-by: Maarten Lankhorst Signed-off-by: Ben Skeggs --- diff --git a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c index 64dca26..fe67415 100644 --- a/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c +++ b/drivers/gpu/drm/nouveau/core/engine/graph/ctxnvc0.c @@ -1039,7 +1039,7 @@ nvc0_grctx_generate_r406800(struct nvc0_graph_priv *priv) } while (!tpcnr[gpc]); tpc = priv->tpc_nr[gpc] - tpcnr[gpc]--; - tpc_set |= 1 << ((gpc * 8) + tpc); + tpc_set |= 1ULL << ((gpc * 8) + tpc); } nv_wr32(priv, 0x406800 + (i * 0x20), lower_32_bits(tpc_set));