From: Rob Herring Date: Fri, 10 Mar 2023 14:47:03 +0000 (-0600) Subject: dmaengine: Use of_property_present() for testing DT property presence X-Git-Tag: v6.6.17~4937^2~52 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3765af04f4fda327463e5b631a4a2d62ae7bb93f;p=platform%2Fkernel%2Flinux-rpi.git dmaengine: Use of_property_present() for testing DT property presence It is preferred to use typed property access functions (i.e. of_property_read_ functions) rather than low-level of_get_property/of_find_property functions for reading properties. As part of this, convert of_get_property/of_find_property calls to the recently added of_property_present() helper when we just want to test for presence of a property and nothing more. Signed-off-by: Rob Herring Link: https://lore.kernel.org/r/20230310144704.1541976-1-robh@kernel.org Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/of-dma.c b/drivers/dma/of-dma.c index ac61ecd..775a7f4 100644 --- a/drivers/dma/of-dma.c +++ b/drivers/dma/of-dma.c @@ -264,7 +264,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np, } /* Silently fail if there is not even the "dmas" property */ - if (!of_find_property(np, "dmas", NULL)) + if (!of_property_present(np, "dmas")) return ERR_PTR(-ENODEV); count = of_property_count_strings(np, "dma-names");