From: Laurent Pinchart Date: Sat, 1 Aug 2015 09:22:53 +0000 (-0300) Subject: [media] v4l: atmel-isi: Simplify error handling during DT parsing X-Git-Tag: v4.14-rc1~4413^2~127 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=375123976f71367c2e14921179149f52b2225746;p=platform%2Fkernel%2Flinux-rpi.git [media] v4l: atmel-isi: Simplify error handling during DT parsing Put the endpoint DT node earlier to avoid the need for goto statements to a cleanup code block in case of errors. Signed-off-by: Laurent Pinchart Tested-by: Josh Wu Signed-off-by: Guennadi Liakhovetski Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index a3ddec7..0f23984 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -899,9 +899,10 @@ static int atmel_isi_probe_dt(struct atmel_isi *isi, } err = v4l2_of_parse_endpoint(np, &ep); + of_node_put(np); if (err) { dev_err(&pdev->dev, "Could not parse the endpoint\n"); - goto err_probe_dt; + return err; } switch (ep.bus.parallel.bus_width) { @@ -915,14 +916,10 @@ static int atmel_isi_probe_dt(struct atmel_isi *isi, default: dev_err(&pdev->dev, "Unsupported bus width: %d\n", ep.bus.parallel.bus_width); - err = -EINVAL; - goto err_probe_dt; + return -EINVAL; } -err_probe_dt: - of_node_put(np); - - return err; + return 0; } static int atmel_isi_probe(struct platform_device *pdev)