From: Lorenzo Bianconi Date: Tue, 23 Aug 2022 13:22:23 +0000 (+0200) Subject: wifi: mac80211: always free sta in __sta_info_alloc in case of error X-Git-Tag: v6.6.17~6688^2~27^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=36fe8e4e5cb02131719612aea1e64379670d1846;p=platform%2Fkernel%2Flinux-rpi.git wifi: mac80211: always free sta in __sta_info_alloc in case of error Free sta pointer in __sta_info_alloc routine if sta_info_alloc_link() fails. Fixes: 246b39e4a1ba5 ("wifi: mac80211: refactor some sta_info link handling") Signed-off-by: Lorenzo Bianconi Link: https://lore.kernel.org/r/a3d079208684cddbc25289f7f7e0fed795b0cad4.1661260857.git.lorenzo@kernel.org Signed-off-by: Johannes Berg --- diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index cb23da9aff1e..330dab41f2fe 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -494,7 +494,7 @@ __sta_info_alloc(struct ieee80211_sub_if_data *sdata, sta->sdata = sdata; if (sta_info_alloc_link(local, &sta->deflink, gfp)) - return NULL; + goto free; if (link_id >= 0) { sta_info_add_link(sta, link_id, &sta->deflink,