From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
Date: Fri, 2 Jan 2015 19:32:12 +0000 (+0100)
Subject: Fix uninitialized variable in Admin::listPolicies()
X-Git-Tag: security-manager_5.5_testing~155
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=36efc47cbf7dfa67e7c01e3efebdddf8d0dcfd30;p=platform%2Fcore%2Ftest%2Fsecurity-tests.git

Fix uninitialized variable in Admin::listPolicies()

struct cynara_admin_policy **policies was uninitialized.
Normally it should be filled with cynara_admin_list_policies() call.
However, when that function failes, it leaves policies unaffected.
If this pointer is not NULL then it is being freed after it is used
to construct vector of policies.

Change-Id: Iff469205035a5240eee64ec87ea724b83577d105
---

diff --git a/tests/cynara-tests/common/cynara_test_admin.cpp b/tests/cynara-tests/common/cynara_test_admin.cpp
index f49e887b..58823f72 100644
--- a/tests/cynara-tests/common/cynara_test_admin.cpp
+++ b/tests/cynara-tests/common/cynara_test_admin.cpp
@@ -266,7 +266,7 @@ void Admin::listPolicies(const char *startBucket,
                          CynaraPoliciesContainer &expectedPolicyList,
                          int expectedResult) {
 
-    struct cynara_admin_policy **policies;
+    struct cynara_admin_policy **policies = nullptr;
 
     int ret = cynara_admin_list_policies(m_admin,
                                          startBucket,