From: Sangchul Lee <sc11.lee@samsung.com>
Date: Mon, 22 Jun 2020 05:39:59 +0000 (+0900)
Subject: Use do-while(0) statement for the macro checking argument
X-Git-Tag: submit/tizen/20200626.085752~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=36bbff27d70cd1f6fc8785c8b1825aef3a0484b0;p=platform%2Fcore%2Fapi%2Fsound-manager.git

Use do-while(0) statement for the macro checking argument

[Version] 0.6.9
[Issue Type] Improvement

Change-Id: If56b0d4839c3b7cec70f136281406bdd0cabd1d7
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/include/sound_manager_private.h b/include/sound_manager_private.h
index 1772cc0..e772db5 100644
--- a/include/sound_manager_private.h
+++ b/include/sound_manager_private.h
@@ -42,11 +42,12 @@ extern "C"
 #include "sound_manager_internal.h"
 
 #define _CHECK_CONDITION(condition, error, msg)     \
-if (condition) { \
-} else { \
-	LOGE("[%s] %s(0x%08x)", __FUNCTION__, msg, error); \
-	return error; \
-}; \
+do { \
+	if (!(condition)) { \
+		LOGE("[%s] %s(0x%08x)", __FUNCTION__, msg, error); \
+		return error; \
+	} \
+} while (0)
 
 #define SM_INSTANCE_CHECK(handle) \
 _CHECK_CONDITION(handle != NULL, SOUND_MANAGER_ERROR_INVALID_PARAMETER, "SOUND_MANAGER_ERROR_INVALID_PARAMETER")
diff --git a/packaging/capi-media-sound-manager.spec b/packaging/capi-media-sound-manager.spec
index 944764e..0f203da 100644
--- a/packaging/capi-media-sound-manager.spec
+++ b/packaging/capi-media-sound-manager.spec
@@ -1,6 +1,6 @@
 Name:       capi-media-sound-manager
 Summary:    Sound Manager library
-Version:    0.6.8
+Version:    0.6.9
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
diff --git a/src/sound_manager_private.c b/src/sound_manager_private.c
index 35544ac..0e0458d 100644
--- a/src/sound_manager_private.c
+++ b/src/sound_manager_private.c
@@ -3336,7 +3336,7 @@ int _get_latest_stream_pid(int stream_type, unsigned int *pid)
 	const gchar *dbus_ret = NULL;
 	unsigned int _pid;
 
-	SM_NULL_ARG_CHECK_FOR_PRIV(pid)
+	SM_NULL_ARG_CHECK_FOR_PRIV(pid);
 
 	if ((ret = __get_dbus_connection(&conn)))
 		return ret;