From: Wei Yongjun Date: Tue, 19 Jul 2016 11:32:43 +0000 (+0000) Subject: drm/rockchip: analogix_dp: add missing clk_disable_unprepare() on error X-Git-Tag: v4.14-rc1~2738^2~7^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3694c5c3dea1fc2150f2ec2a036fee298680c0e0;p=platform%2Fkernel%2Flinux-rpi.git drm/rockchip: analogix_dp: add missing clk_disable_unprepare() on error Add the missing clk_disable_unprepare() before return in the error handling case. Signed-off-by: Wei Yongjun Signed-off-by: Sean Paul --- diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index e81e19a..89aadbf 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -96,6 +96,7 @@ static int rockchip_dp_poweron(struct analogix_dp_plat_data *plat_data) ret = rockchip_dp_pre_init(dp); if (ret < 0) { dev_err(dp->dev, "failed to dp pre init %d\n", ret); + clk_disable_unprepare(dp->pclk); return ret; } @@ -272,6 +273,7 @@ static int rockchip_dp_init(struct rockchip_dp_device *dp) ret = rockchip_dp_pre_init(dp); if (ret < 0) { dev_err(dp->dev, "failed to pre init %d\n", ret); + clk_disable_unprepare(dp->pclk); return ret; }