From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Thu, 27 Jul 2023 07:16:33 +0000 (+0300)
Subject: ALSA: hda/cs35l56: Do some clean up on probe error
X-Git-Tag: v6.6.7~1940^2~15^2~84
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=367ef1e1c4b65acc5d789ba00d20197eb66b62f4;hp=a32e0834df769a153419fd2c88d19704ae67cf18;p=platform%2Fkernel%2Flinux-starfive.git

ALSA: hda/cs35l56: Do some clean up on probe error

Smatch complains that this return should be a goto:

    sound/pci/hda/cs35l56_hda.c:910 cs35l56_hda_common_probe()
    warn: missing unwind goto?

The goto error disables cansleep so that seems reasonable.

Fixes: 73cfbfa9caea ("ALSA: hda/cs35l56: Add driver for Cirrus Logic CS35L56 amplifier")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/465160f4-b7cf-41d5-931e-d6c9e68fa3c7@moroto.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/hda/cs35l56_hda.c b/sound/pci/hda/cs35l56_hda.c
index 71e95e6..4c3279f 100644
--- a/sound/pci/hda/cs35l56_hda.c
+++ b/sound/pci/hda/cs35l56_hda.c
@@ -907,7 +907,7 @@ int cs35l56_hda_common_probe(struct cs35l56_hda *cs35l56, int id)
 
 	ret = cs35l56_set_patch(&cs35l56->base);
 	if (ret)
-		return ret;
+		goto err;
 
 	regcache_mark_dirty(cs35l56->base.regmap);
 	regcache_sync(cs35l56->base.regmap);