From: Guenter Roeck Date: Fri, 27 Mar 2015 01:36:30 +0000 (-0700) Subject: net: dsa: mv88e6xxx: Disable Message Port bit for CPU port X-Git-Tag: v5.15~15978^2~124^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=366f0a0f98370d435de64978d623e6abf2630b01;p=platform%2Fkernel%2Flinux-starfive.git net: dsa: mv88e6xxx: Disable Message Port bit for CPU port Datasheet says that the Message Port bit should not be set for the CPU port. Having it set causes DSA tagged packets to be sent to the CPU port roughly every 30 seconds. Those packets are the same as real packets forwarded between switch ports if the switch is configured for switching between multiple ports. The packets are then bridged by the software bridge, resulting in duplicated packets on the network. Reported-by: Andrew Lunn Cc: Andrew Lunn Reviewed-by: Andrew Lunn Tested-by: Andrew Lunn Signed-off-by: Guenter Roeck Signed-off-by: David S. Miller --- diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c index 2052e51..5da50b0 100644 --- a/drivers/net/dsa/mv88e6xxx.c +++ b/drivers/net/dsa/mv88e6xxx.c @@ -707,11 +707,10 @@ int mv88e6xxx_setup_port_common(struct dsa_switch *ds, int port) mutex_lock(&ps->smi_mutex); - /* Port Control 1: disable trunking. Also, if this is the - * CPU port, enable learn messages to be sent to this port. + /* Port Control 1: disable trunking, disable sending + * learning messages to this port. */ - ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x05, - dsa_is_cpu_port(ds, port) ? 0x8000 : 0x0000); + ret = _mv88e6xxx_reg_write(ds, REG_PORT(port), 0x05, 0x0000); if (ret) goto abort;