From: Sangchul Lee <sc11.lee@samsung.com>
Date: Mon, 7 Sep 2020 08:56:11 +0000 (+0900)
Subject: webrtc_test: Check URL length before setting it
X-Git-Tag: submit/tizen/20210729.023123~228
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3657dbf30814b9605bccd9d9d686985cc65cde5d;p=platform%2Fcore%2Fapi%2Fwebrtc.git

webrtc_test: Check URL length before setting it

Two similar functions are merged into one.

[Version] 0.1.14
[Issue Type] Test application

Change-Id: I6e0760278b177eef6a3d835fe2d59910ca91a6b2
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
---

diff --git a/test/webrtc_test.c b/test/webrtc_test.c
index d66cd321..241cc54e 100644
--- a/test/webrtc_test.c
+++ b/test/webrtc_test.c
@@ -452,28 +452,20 @@ static void _webrtc_set_remote_description(char *desc)
 		g_print("webrtc_set_remote_description() success\n");
 }
 
-static void _setting_signaling_server(char *uri)
+static void _setting_uri(gchar *dest_arr, char *uri)
 {
 	int ret = 0;
 
 	if (!uri)
 		return;
 
-	ret = __copy_string_arr(g_signaling_server, uri);
-	if (ret != 0)
-		return;
-}
-
-static void _setting_proxy(char *uri)
-{
-	int ret = 0;
-
-	if (!uri)
-		return;
-
-	ret = __copy_string_arr(g_proxy, uri);
-	if (ret != 0)
-		return;
+	if (strlen(uri) > strlen("0.0.0.0")) {
+		ret = __copy_string_arr(dest_arr, uri);
+		if (ret != 0)
+			g_print("failed to __copy_string_arr()\n");
+	} else {
+		g_print("invalid value, uri[%s]\n", uri);
+	}
 }
 
 void quit_program()
@@ -589,8 +581,8 @@ void display_sub_basic()
 	g_print("sr. Set remote description\n");
 	g_print("st. Set STUN server\n");
 	g_print("----------------------------------- App. Setting ----------------------------------------\n");
-	g_print("ss. Signalling server\n");
-	g_print("px. Proxy\n");
+	g_print("ss. Set signaling server URL\n");
+	g_print("px. Set proxy URL\n");
 	g_print("-----------------------------------------------------------------------------------------\n");
 	g_print("=========================================================================================\n");
 }
@@ -610,9 +602,9 @@ static void displaymenu()
 	} else if (g_menu_state == CURRENT_STATUS_SET_REMOTE_DESCRIPTION) {
 		g_print("*** input type of remote description.(1:offer, 2:answer)\n");
 	} else if (g_menu_state == CURRENT_STATUS_SETTING_SIGNALING_SERVER) {
-		g_print("*** input signaling server url.\n");
+		g_print("*** input signaling server URL.\n");
 	} else if (g_menu_state == CURRENT_STATUS_SETTING_PROXY) {
-		g_print("*** input proxy address.\n");
+		g_print("*** input proxy URL.\n");
 	} else {
 		g_print("*** unknown status.\n");
 		quit_program();
@@ -704,12 +696,12 @@ static void interpret(char *cmd)
 		break;
 	}
 	case CURRENT_STATUS_SETTING_SIGNALING_SERVER: {
-		_setting_signaling_server(cmd);
+		_setting_uri(g_signaling_server, cmd);
 		reset_menu_state();
 		break;
 	}
 	case CURRENT_STATUS_SETTING_PROXY: {
-		_setting_proxy(cmd);
+		_setting_uri(g_proxy, cmd);
 		reset_menu_state();
 		break;
 	}