From: Ben Dooks Date: Tue, 22 Sep 2009 23:47:43 +0000 (-0700) Subject: s3c2410fb: fix clockrate calculation X-Git-Tag: v2.6.32-rc1~194 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=360fa58828784f307c3977d5ff4c8e400f074a56;p=platform%2Fkernel%2Flinux-stable.git s3c2410fb: fix clockrate calculation In the final part of the calculation for the tft display clockrate we divide the output pf s3c2410fb_calc_pixclk() by 2 which leaves us with a rounding error if the result is odd. Change to using DIV_ROUND_UP() to ensure that we always choose a higher divisor and thus a lower frequency. Signed-off-by: Ben Dooks Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/s3c2410fb.c b/drivers/video/s3c2410fb.c index 5ffca2a..aac6612 100644 --- a/drivers/video/s3c2410fb.c +++ b/drivers/video/s3c2410fb.c @@ -369,7 +369,9 @@ static void s3c2410fb_activate_var(struct fb_info *info) void __iomem *regs = fbi->io; int type = fbi->regs.lcdcon1 & S3C2410_LCDCON1_TFT; struct fb_var_screeninfo *var = &info->var; - int clkdiv = s3c2410fb_calc_pixclk(fbi, var->pixclock) / 2; + int clkdiv; + + clkdiv = DIV_ROUND_UP(s3c2410fb_calc_pixclk(fbi, var->pixclock), 2); dprintk("%s: var->xres = %d\n", __func__, var->xres); dprintk("%s: var->yres = %d\n", __func__, var->yres);