From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Mon, 18 Jan 2016 12:52:29 +0000 (+0100)
Subject: netfilter: nf_tables_netdev: fix error path in module initialization
X-Git-Tag: v6.1~17226^2~58^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=35b815392a6b6c268baf3b63d7f2ba350597024f;p=sdk%2Femulator%2Femulator-kernel.git

netfilter: nf_tables_netdev: fix error path in module initialization

Unregister the chain type and return error, otherwise this leaks the
subscription to the netdevice notifier call chain.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nf_tables_netdev.c b/net/netfilter/nf_tables_netdev.c
index b6605e000801..5eefe4a355c6 100644
--- a/net/netfilter/nf_tables_netdev.c
+++ b/net/netfilter/nf_tables_netdev.c
@@ -224,12 +224,12 @@ static int __init nf_tables_netdev_init(void)
 
 	nft_register_chain_type(&nft_filter_chain_netdev);
 	ret = register_pernet_subsys(&nf_tables_netdev_net_ops);
-	if (ret < 0)
+	if (ret < 0) {
 		nft_unregister_chain_type(&nft_filter_chain_netdev);
-
+		return ret;
+	}
 	register_netdevice_notifier(&nf_tables_netdev_notifier);
-
-	return ret;
+	return 0;
 }
 
 static void __exit nf_tables_netdev_exit(void)