From: Laurent Pinchart Date: Mon, 9 May 2022 22:32:33 +0000 (+0100) Subject: media: staging: media: imx: imx7-media-csi: Drop error message on alloc failure X-Git-Tag: v6.1-rc5~729^2~169 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=35b53d44e1bae0d98c75d0262d98dea3cd6037ce;p=platform%2Fkernel%2Flinux-starfive.git media: staging: media: imx: imx7-media-csi: Drop error message on alloc failure The kernel memory allocators already complain loudly to the log when allocation fails. There's no need for an additional message. Signed-off-by: Laurent Pinchart Acked-by: Rui Miguel Silva Tested-by: Alexander Stein Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index 4f65e12..52653f9 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -442,10 +442,8 @@ static int imx7_csi_alloc_dma_buf(struct imx7_csi *csi, buf->len = PAGE_ALIGN(size); buf->virt = dma_alloc_coherent(csi->dev, buf->len, &buf->phys, GFP_DMA | GFP_KERNEL); - if (!buf->virt) { - dev_err(csi->dev, "%s: failed\n", __func__); + if (!buf->virt) return -ENOMEM; - } return 0; }