From: Trond Myklebust Date: Mon, 28 May 2012 14:01:34 +0000 (-0400) Subject: NFSv4: update_changeattr does not need to set NFS_INO_REVAL_PAGECACHE X-Git-Tag: v3.5-rc1~52^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=359d7d1c976851c658aa7085761015812ed3b56f;p=profile%2Fcommon%2Fkernel-common.git NFSv4: update_changeattr does not need to set NFS_INO_REVAL_PAGECACHE We're already invalidating the data cache, and setting the new change attribute. Since directories don't care about the i_size field, there is no need to be forcing any extra revalidation of the page cache. We do keep the NFS_INO_INVALID_ATTR flag, in order to force an attribute cache revalidation on stat() calls since we do not update the mtime and ctime fields. Signed-off-by: Trond Myklebust --- diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c index 6be5fa3..af2db2c 100644 --- a/fs/nfs/nfs4proc.c +++ b/fs/nfs/nfs4proc.c @@ -774,7 +774,7 @@ static void update_changeattr(struct inode *dir, struct nfs4_change_info *cinfo) struct nfs_inode *nfsi = NFS_I(dir); spin_lock(&dir->i_lock); - nfsi->cache_validity |= NFS_INO_INVALID_ATTR|NFS_INO_REVAL_PAGECACHE|NFS_INO_INVALID_DATA; + nfsi->cache_validity |= NFS_INO_INVALID_ATTR|NFS_INO_INVALID_DATA; if (!cinfo->atomic || cinfo->before != dir->i_version) nfs_force_lookup_revalidate(dir); dir->i_version = cinfo->after;