From: René Stadler Date: Wed, 29 Jun 2011 16:50:42 +0000 (+0300) Subject: pulsesink: remove unused member variable and misleading log message X-Git-Tag: 1.19.3~509^2~7136^2~465 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3589cee762e8bb6bf4da6bb52a58554b61de66a0;p=platform%2Fupstream%2Fgstreamer.git pulsesink: remove unused member variable and misleading log message Wim changed it in commit 8bfd80 so that pa_defer_ran is not read anywhere. The log message used to annotate a mainloop_wait call which is gone. --- diff --git a/ext/pulse/pulsesink.c b/ext/pulse/pulsesink.c index 3464799..2537f75 100644 --- a/ext/pulse/pulsesink.c +++ b/ext/pulse/pulsesink.c @@ -1006,7 +1006,6 @@ mainloop_enter_defer_cb (pa_mainloop_api * api, void *userdata) gst_element_post_message (GST_ELEMENT (pulsesink), message); /* signal the waiter */ - pulsesink->pa_defer_ran = TRUE; pa_threaded_mainloop_signal (mainloop, 0); } @@ -1023,7 +1022,6 @@ gst_pulseringbuffer_start (GstRingBuffer * buf) pa_threaded_mainloop_lock (mainloop); GST_DEBUG_OBJECT (psink, "scheduling stream status"); - psink->pa_defer_ran = FALSE; pa_mainloop_api_once (pa_threaded_mainloop_get_api (mainloop), mainloop_enter_defer_cb, psink); @@ -1083,7 +1081,6 @@ mainloop_leave_defer_cb (pa_mainloop_api * api, void *userdata) gst_message_set_stream_status_object (message, &val); gst_element_post_message (GST_ELEMENT (pulsesink), message); - pulsesink->pa_defer_ran = TRUE; pa_threaded_mainloop_signal (mainloop, 0); gst_object_unref (pulsesink); } @@ -1129,12 +1126,10 @@ cleanup: } GST_DEBUG_OBJECT (psink, "scheduling stream status"); - psink->pa_defer_ran = FALSE; gst_object_ref (psink); pa_mainloop_api_once (pa_threaded_mainloop_get_api (mainloop), mainloop_leave_defer_cb, psink); - GST_DEBUG_OBJECT (psink, "waiting for stream status"); pa_threaded_mainloop_unlock (mainloop); return res; diff --git a/ext/pulse/pulsesink.h b/ext/pulse/pulsesink.h index 0f75fcc..e3cbbca 100644 --- a/ext/pulse/pulsesink.h +++ b/ext/pulse/pulsesink.h @@ -64,8 +64,6 @@ struct _GstPulseSink gboolean mute:1; gboolean mute_set:1; - gboolean pa_defer_ran:1; - gint notify; /* atomic */ const gchar *pa_version;