From: YOSHIFUJI Hideaki Date: Wed, 21 Nov 2007 01:30:31 +0000 (-0800) Subject: [IPV4] TCPMD5: Use memmove() instead of memcpy() because we have overlaps. X-Git-Tag: v2.6.24-rc4~8^2~39 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=354faf0977397cea382e9e9c214fd028377d277b;p=platform%2Fkernel%2Flinux-3.10.git [IPV4] TCPMD5: Use memmove() instead of memcpy() because we have overlaps. Signed-off-by: YOSHIFUJI Hideaki Signed-off-by: David S. Miller --- diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c index ff36096..652c323 100644 --- a/net/ipv4/tcp_ipv4.c +++ b/net/ipv4/tcp_ipv4.c @@ -938,10 +938,10 @@ int tcp_v4_md5_do_del(struct sock *sk, __be32 addr) tp->md5sig_info->alloced4 = 0; } else if (tp->md5sig_info->entries4 != i) { /* Need to do some manipulation */ - memcpy(&tp->md5sig_info->keys4[i], - &tp->md5sig_info->keys4[i+1], - (tp->md5sig_info->entries4 - i) * - sizeof(struct tcp4_md5sig_key)); + memmove(&tp->md5sig_info->keys4[i], + &tp->md5sig_info->keys4[i+1], + (tp->md5sig_info->entries4 - i) * + sizeof(struct tcp4_md5sig_key)); } tcp_free_md5sig_pool(); return 0;