From: Vandana BN Date: Mon, 13 May 2019 13:43:24 +0000 (+0530) Subject: Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing... X-Git-Tag: v5.4-rc1~602^2~496 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3544d3f785c12754f156a15020579d2875e98240;p=platform%2Fkernel%2Flinux-rpi.git Staging: kpc2000: kpc_dma: Resolve checkpath errors Macros in paranthesis & trailing statements on next line. This patch fixes below errors reported by checkpath ERROR: Macros with complex values should be enclosed in parentheses CHECK: Prefer using the BIT macro ERROR: trailing statements should be on next line ERROR: trailing statements should be on next line Signed-off-by: Vandana BN Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c index 0b8dcf0..e996ced 100644 --- a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c +++ b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c @@ -14,7 +14,7 @@ MODULE_LICENSE("GPL"); MODULE_AUTHOR("Matt.Sickler@daktronics.com"); #define KPC_DMA_CHAR_MAJOR UNNAMED_MAJOR -#define KPC_DMA_NUM_MINORS 1 << MINORBITS +#define KPC_DMA_NUM_MINORS BIT(MINORBITS) static DEFINE_MUTEX(kpc_dma_mtx); static int assigned_major_num; static LIST_HEAD(kpc_dma_list); @@ -55,9 +55,11 @@ static ssize_t show_engine_regs(struct device *dev, struct device_attribute *at { struct kpc_dma_device *ldev; struct platform_device *pldev = to_platform_device(dev); - if (!pldev) return 0; + if (!pldev) + return 0; ldev = platform_get_drvdata(pldev); - if (!ldev) return 0; + if (!ldev) + return 0; return scnprintf(buf, PAGE_SIZE, "EngineControlStatus = 0x%08x\n"