From: Roel Kluin Date: Mon, 15 Feb 2010 21:57:24 +0000 (+0100) Subject: mtd: inftl: misplaced parenthesis in find_boot_record X-Git-Tag: 2.1b_release~8366^2~112 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=35109451f18280000ce5e7b76ac8d29eb222823b;p=platform%2Fkernel%2Fkernel-mfld-blackbay.git mtd: inftl: misplaced parenthesis in find_boot_record The parenthesis was misplaced, upon error a one was shown. [dwmw2: Fix the code not to do the assignment within the if() statement] Signed-off-by: Roel Kluin Signed-off-by: Artem Bityutskiy Signed-off-by: David Woodhouse --- diff --git a/drivers/mtd/inftlmount.c b/drivers/mtd/inftlmount.c index 32e82ae..8f988d7 100644 --- a/drivers/mtd/inftlmount.c +++ b/drivers/mtd/inftlmount.c @@ -100,9 +100,10 @@ static int find_boot_record(struct INFTLrecord *inftl) } /* To be safer with BIOS, also use erase mark as discriminant */ - if ((ret = inftl_read_oob(mtd, block * inftl->EraseSize + - SECTORSIZE + 8, 8, &retlen, - (char *)&h1) < 0)) { + ret = inftl_read_oob(mtd, + block * inftl->EraseSize + SECTORSIZE + 8, + 8, &retlen,(char *)&h1); + if (ret < 0) { printk(KERN_WARNING "INFTL: ANAND header found at " "0x%x in mtd%d, but OOB data read failed " "(err %d)\n", block * inftl->EraseSize,